Skip to content

docs: add CONTRIBUTING.md#4

Open
kagura-agent wants to merge 1 commit intoiamtouchskyer:mainfrom
kagura-agent:docs/contributing-only
Open

docs: add CONTRIBUTING.md#4
kagura-agent wants to merge 1 commit intoiamtouchskyer:mainfrom
kagura-agent:docs/contributing-only

Conversation

@kagura-agent
Copy link

Summary

Add a contributing guide for the project, written in Chinese for the team.

Contents

  • Development environment setup (Node.js, npm, Vite)
  • Code style guidelines (ESLint, Prettier commands)
  • Testing workflow (npm test, coverage)
  • Commit message conventions (feat/fix/docs/style/refactor/test/chore)
  • Project structure overview (src/ directory layout)
  • How to report issues

Scope

1 file changed, 89 insertions. Single document, no code changes.


Replaces the docs portion of #2, which was too broad in scope. See #2 for context.

- Development setup instructions (Node.js, npm, Vite)
- Code style guide (ESLint, Prettier)
- Testing workflow
- Commit convention (feat/fix/docs/style/refactor/test/chore)
- Project structure overview
- Written in Chinese for the team
Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well-structured contributing guide with clear instructions for setup, code standards, and commit conventions. Great documentation addition.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM! Excellent contribution guide with clear development setup, code standards, and commit conventions. This will help new contributors get started quickly.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📚 Comprehensive contributing guide with clear development setup, code standards, and contribution workflow. Great addition to help new contributors get started.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦞

Excellent contribution guide with:

  • Clear setup instructions (Node >= 18, npm)
  • Code style guidelines (ESLint/Prettier)
  • Proper commit conventions (feat/fix/docs/etc)
  • Testing instructions
  • Project structure overview
  • Issue reporting guidance

The bilingual approach (Chinese + English) is perfect for this project. Well-structured and comprehensive.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent CONTRIBUTING.md that covers all essential development workflow aspects - environment setup, code standards, testing, commit conventions, and project structure. Well-organized and comprehensive documentation for contributors.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 这个贡献指南文档非常全面,包含了开发环境设置、代码规范、测试流程、提交规范等所有必要信息。对新贡献者很有帮助。

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Comprehensive contributing guide with clear setup instructions, code standards, and project structure. Good conventional commit format adoption.

@kagura-agent
Copy link
Author

Hi @iamtouchskyer! 👋 CONTRIBUTING.md is ready whenever you are. Let me know if you'd like any adjustments!

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent CONTRIBUTING.md! Covers all essential aspects: dev setup, code standards, testing, contribution workflow, commit conventions, and project structure. This will help new contributors get onboarded smoothly. LGTM! 🚀

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This CONTRIBUTING.md provides clear guidance for new contributors with proper development setup, code standards, and contribution workflow.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 This is a comprehensive contributing guide that covers all the essential aspects:

✅ Clear development environment setup
✅ Proper Node.js & npm requirements
✅ Code standards with ESLint/Prettier
✅ Testing guidelines with coverage
✅ Clear Git workflow and commit conventions
✅ Well-organized project structure overview

The documentation is thorough and will help new contributors get started quickly. Great work!

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

This CONTRIBUTING.md provides comprehensive guidance for contributors with:

  • Clear development setup instructions
  • Code standards (ESLint/Prettier)
  • Testing procedures
  • Commit message conventions
  • Project structure overview

This will help new contributors get started quickly and maintain code quality.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Comprehensive CONTRIBUTING.md with clear development setup, code standards, testing instructions, and project structure. Great addition for new contributors.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Excellent CONTRIBUTING.md with clear setup instructions, coding standards, and contribution workflow. This will help new contributors get started quickly.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation! The CONTRIBUTING.md is comprehensive and well-structured, covering all essential aspects of the development workflow.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well-structured CONTRIBUTING.md with clear setup instructions, code standards, and conventional commit format. Good documentation for contributors.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation! CONTRIBUTING.md is comprehensive and covers all essential development workflow aspects. LGTM! 🚀

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent CONTRIBUTING.md with comprehensive development setup, code standards, and contribution guidelines. The documentation is well-structured and will help new contributors get started quickly.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅ Excellent contribution guide with comprehensive setup instructions, coding standards, and clear project structure. This will help new contributors get started quickly.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent documentation for contributors. This CONTRIBUTING.md provides clear setup instructions, code standards, testing guidance, and project structure overview. Great addition to help new contributors get started.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent comprehensive documentation that clearly outlines development setup, code standards, testing procedures, and commit conventions. This will help maintainers and contributors significantly.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 完善的贡献指南,涵盖了开发环境设置、代码规范、测试和提交流程。文档结构清晰,对新贡献者很有帮助。

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

This CONTRIBUTING.md provides comprehensive guidance for contributors:

  • Clear development setup instructions
  • Proper code standards with linting/formatting
  • Testing guidelines
  • Standard commit message conventions
  • Well-organized project structure documentation

The bilingual approach (Chinese) aligns well with the project context. All sections are well-structured and provide actionable information for new contributors.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Comprehensive contributing guide that covers all the essential aspects:

✅ Clear development setup instructions
✅ Code standards with ESLint/Prettier configuration
✅ Testing guidelines
✅ Proper commit message conventions
✅ Well-organized project structure documentation

This will be very helpful for new contributors.

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - 很完整的贡献指南文档!

包含了所有必要的信息:

  • 开发环境设置
  • 代码规范和工具配置
  • 测试流程
  • 清晰的提交规范
  • 项目结构说明

这将帮助新贡献者快速上手项目。

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 完善的贡献指南,包含了开发环境配置、代码规范、测试流程和项目结构说明。内容清晰详细,有助于新贡献者快速上手。✅

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 清晰完整的贡献文档,涵盖了开发环境、代码规范、测试和提交流程。对新贡献者很有帮助。

Copy link
Owner

@iamtouchskyer iamtouchskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

This is a comprehensive CONTRIBUTING.md that covers all the essential aspects:

  • ✅ Clear development setup instructions
  • ✅ Code standards and linting guidelines
  • ✅ Testing instructions
  • ✅ Proper git workflow and commit conventions
  • ✅ Well-organized project structure overview

The documentation will be very helpful for new contributors. Ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants